Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[core] fix sleep mode in pytorch 2.6 #13456

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Feb 18, 2025

as observed in #12721 , Basic Correctness case basic_correctness/test_cumem.py::test_end_to_end[meta-llama/Llama-3.2-1B-Instruct] has a segfault due to enable_sleep_mode=True , but another test with opt-125m passed.

I locally tested that this fixes the bug in pytorch 2.6

Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao youkaichao requested a review from mgoin February 18, 2025 04:56
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this 🙏

@youkaichao youkaichao merged commit ac19b51 into vllm-project:main Feb 18, 2025
19 of 26 checks passed
@youkaichao youkaichao deleted the fix_cumem_test branch February 18, 2025 05:48
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants