Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bugfix] Remove noisy error logging during local model loading #13458

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Feb 18, 2025

Signed-off-by: Isotr0py <2037008807@qq.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py changed the title [Bugfix] Fix failing local model loading [Bugfix] Fix broken local model loading Feb 18, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 05:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py changed the title [Bugfix] Fix broken local model loading [Bugfix] Remove noisy error logging during local model loading Feb 18, 2025
@simon-mo simon-mo merged commit 29fc577 into vllm-project:main Feb 18, 2025
28 of 31 checks passed
@Isotr0py Isotr0py deleted the fix-local branch February 18, 2025 11:16
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants