Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ROCm] Make amdsmi import optional for other platforms #13460

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

DarkLight1337
Copy link
Member

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

from amdsmi import (amdsmi_get_gpu_asic_info, amdsmi_get_processor_handles,
amdsmi_init, amdsmi_shut_down)
except ImportError as e:
logger.warning("Failed to import from amdsmi with %r", e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test locally to see if fail to import (amdsmi_get_gpu_asic_info, amdsmi_get_processor_handles, amdsmi_init, amdsmi_shut_down) can still pass the test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested test_attention_selector.py, test_mha_attn.py and test_rocm_attention_selector.py and they all pass.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 06:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
@DarkLight1337 DarkLight1337 changed the title [ROCm] Make amdsmi import optional [ROCm] Make amdsmi import optional for other platforms Feb 18, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 06:37
@simon-mo simon-mo merged commit 435b502 into vllm-project:main Feb 18, 2025
49 of 55 checks passed
@DarkLight1337 DarkLight1337 deleted the lazy-amdsmi branch February 18, 2025 11:16
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants