-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[ROCm] Make amdsmi import optional for other platforms #13460
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
from amdsmi import (amdsmi_get_gpu_asic_info, amdsmi_get_processor_handles, | ||
amdsmi_init, amdsmi_shut_down) | ||
except ImportError as e: | ||
logger.warning("Failed to import from amdsmi with %r", e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test locally to see if fail to import (amdsmi_get_gpu_asic_info, amdsmi_get_processor_handles, amdsmi_init, amdsmi_shut_down)
can still pass the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested test_attention_selector.py
, test_mha_attn.py
and test_rocm_attention_selector.py
and they all pass.
…13460) Signed-off-by: Linkun Chen <github@lkchen.net>
…13460) Signed-off-by: saeediy <saidakbarp@gmail.com>
This fixes broken CI on other platforms: https://buildkite.com/vllm/ci/builds/13649#0195176d-c5df-4dfc-91dd-4e1b7b2bc14a