Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[3/n][CI] Load Quantization test models with S3 #13570

Merged
merged 4 commits into from
Feb 20, 2025
Merged

[3/n][CI] Load Quantization test models with S3 #13570

merged 4 commits into from
Feb 20, 2025

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Feb 19, 2025 •
edited by github-actions bot
Loading

  • Add models used in tests/quantization to list of S3 models

cc @DarkLight1337 this PR also reverts the change you mentioned in 1/n PR

EC2 Default User added 3 commits February 19, 2025 19:23
p
5bbfd88 
Signed-off-by:  <>
p
0c65193 
Signed-off-by:  <>
p
aaf8329 
Signed-off-by:  <>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

p
e7d9d9c 
Signed-off-by:  <>
@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 20, 2025
@DarkLight1337 DarkLight1337 merged commit 473f51c into main Feb 20, 2025
61 of 62 checks passed
@DarkLight1337 DarkLight1337 deleted the khluu/s3ci2 branch February 20, 2025 02:12
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@khluu
[3/n][CI] Load Quantization test models with S3 (vllm-project#13570)
055109b 
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@khluu @kerthcet
[3/n][CI] Load Quantization test models with S3 (vllm-project#13570)
6f3946a 
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
michaelrglass pushed a commit to michaelrglass/vllm that referenced this pull request Feb 21, 2025
@khluu @michaelrglass
[3/n][CI] Load Quantization test models with S3 (vllm-project#13570)
804c947 
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: Michael Glass <mrglass@us.ibm.com>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@khluu @Akshat-Tripathi
[3/n][CI] Load Quantization test models with S3 (vllm-project#13570)
ad6b051 
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
@khluu @lk-chen
[3/n][CI] Load Quantization test models with S3 (vllm-project#13570)
2748c74 
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
@khluu @Said-Akbar
[3/n][CI] Load Quantization test models with S3 (vllm-project#13570)
7f175cd 
Signed-off-by: <>
Co-authored-by: EC2 Default User <ec2-user@ip-172-31-20-117.us-west-2.compute.internal>
Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khluu @DarkLight1337