Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Model] Update Paligemma multimodal processing with PromptUpdate #14015

Merged
merged 15 commits into from
Mar 6, 2025
Merged

[Model] Update Paligemma multimodal processing with PromptUpdate #14015

merged 15 commits into from
Mar 6, 2025

Conversation

kylehh
Copy link
Contributor

@kylehh kylehh commented Feb 28, 2025 •
edited by github-actions bot
Loading

Continue work from #13584

  1. Update MM processing with PromptUpdate
  2. Fixed the issue of can not identify language with "caption <lang>" prompt

Note

  1. Use PromptReplacement for paligemma and PromptInsertion for Paligemma 2
  2. The issue was due to HF encode prompt adding <bos> before <image> tokens (ref here) > . The fix was to remove <bos> for baseline result to pass text_common test

@kylehh
promptupdatae
fc30f67 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@kylehh
format
175eb2a 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify Mergify
Copy link

mergify bot commented Feb 28, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @kylehh.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 28, 2025
@kylehh kylehh mentioned this pull request Feb 28, 2025
Closed
@mergify mergify bot removed the needs-rebase label Feb 28, 2025
@DarkLight1337
Copy link
Member

Please also merge the latest changes from #14038

@kylehh
remove modification for HF process result
fe7fa15 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 28, 2025
@kylehh
import update
4648862 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 4, 2025
@DarkLight1337
Copy link
Member

It looks like multi-modal tests is still failing. To get around the accuracy issue, feel free to switch to PaliGemma 2.

@kylehh
use paligemma2 for test
03630e6 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@DarkLight1337
Copy link
Member

It looks like multi-modal tests is still failing. To get around the accuracy issue, feel free to switch to PaliGemma 2.

We can still keep PaliGemma 1 in test_common.py, just not in the model correctness tests.

@kylehh
update max_model_len=8192 for paligemma2 model accuracy test case
ba76f55 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@DarkLight1337 DarkLight1337 mentioned this pull request Mar 5, 2025
Open
49 tasks
kylehh and others added 4 commits March 5, 2025 08:22
@kylehh
skip accuracy test for paligemma due to missing prefix-LM atten
8648448 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@kylehh
add paligemma2 in mm/processing/test_common
eaac52f 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@kylehh
remove SupportV0Only tag
56dd936 
Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
@DarkLight1337
Update docs
9fcf814 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 6, 2025 06:27
DarkLight1337
DarkLight1337 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the docs for you. Thanks for your hard work!

@DarkLight1337
Update test
bbc1a28 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 merged commit 1769928 into vllm-project:main Mar 6, 2025
35 of 36 checks passed
johnnynunez pushed a commit to johnnynunez/vllm that referenced this pull request Mar 6, 2025
@kylehh @DarkLight1337 @johnnynunez
[Model] Update Paligemma multimodal processing with PromptUpdate (vll…
d4e3b50 
…m-project#14015)

Signed-off-by: Kyle Huang <kylhuang@nvidia.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
Signed-off-by: Johnny <johnnynuca14@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@simon-mo simon-mo Awaiting requested review from simon-mo

@mgoin mgoin Awaiting requested review from mgoin

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

@comaniac comaniac Awaiting requested review from comaniac

@njhill njhill Awaiting requested review from njhill

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehh @DarkLight1337