Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Docs] Fix readthedocs for tag build #6158

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented Jul 5, 2024

https://readthedocs.org/projects/vllm/builds/24917886/

image

Readthedocs will first build html successfully on tag, then run into file not found when building pdf, because template is already remvoed.

@simon-mo simon-mo requested a review from youkaichao July 5, 2024 19:36
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@simon-mo simon-mo merged commit 79d406e into vllm-project:main Jul 5, 2024
30 of 33 checks passed
@WoosukKwon
Copy link
Collaborator

Amazing! Thanks for the bug fix!

robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jul 7, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants