Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Misc] Directly use compressed-tensors for checkpoint definitions #8909

Merged
merged 5 commits into from
Oct 15, 2024
Merged

[Misc] Directly use compressed-tensors for checkpoint definitions #8909

merged 5 commits into from
Oct 15, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Sep 27, 2024 •
edited
Loading

Reuse existing implementations of compression and quantization configs defined by compressed-tensors by adding as a dependency

The reused classes are

  1. CompressionFormat
  2. QuantizationArgs
  3. QuantizationStrategy
  4. QuantizationType
  5. ActivationOrdering

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 27, 2024
kylesayrs
kylesayrs approved these changes Oct 1, 2024
View reviewed changes
@kylesayrs
Copy link
Contributor

Previously reverted by #7521 due to accelerate dependency issue. Since then, compressed-tensors==0.5.0 no longer requires accelerate

kylesayrs
kylesayrs suggested changes Oct 1, 2024
View reviewed changes
@DarkLight1337
Copy link
Member

The CI failures should be fixed now that I've merged from main.

russellb
russellb approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simon-mo simon-mo merged commit 22f8a69 into main Oct 15, 2024
74 of 77 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
@mgoin @DarkLight1337 @charlifu
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
f487b65 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: charlifu <charlifu@amd.com>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
@mgoin @DarkLight1337 @vrdn-23
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
06abc6d 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@mgoin @DarkLight1337 @Alvant
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
3525b76 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Alvant <alvasian@yandex.ru>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
@mgoin @DarkLight1337 @garg-amit
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
c9929b8 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
@simon-mo simon-mo deleted the use-compressed-tensors-directly branch October 28, 2024 16:51
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@mgoin @DarkLight1337 @FerdinandZhong
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
43b6efe 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: qishuai <ferdinandzhong@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@mgoin @DarkLight1337 @sumitd2
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
3295ca1 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@mgoin @DarkLight1337
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
9155bc2 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@mgoin @DarkLight1337 @mfournioux
[Misc] Directly use compressed-tensors for checkpoint definitions (vl…
6277ddb 
…lm-project#8909)

Co-authored-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kylesayrs kylesayrs kylesayrs requested changes

@russellb russellb russellb approved these changes

@dsikka dsikka dsikka approved these changes

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mgoin @kylesayrs @DarkLight1337 @russellb @dsikka @robertgshaw2-redhat @simon-mo