-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Doc] Use shell code-blocks and fix section headers #9508
Conversation
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @rafvasq
Actually, I think |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
That's true @DarkLight1337, although in this case these commands are meant to be run in terminal, so I updated the commands to include a prompt symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Erkin Sagiroglu <erkin@infra-aipipeline-1-at1-prox-prod-a.ipa.corp.telnyx.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: qishuai <ferdinandzhong@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Follow up to #9132, #9256
console
instead ofshell
in code-blocks as listed here.