[CI/Build] Add error matching for ruff output #9513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
`ruff` has built-in support for generating errors in a format that GitHub understands so that errors will be shown in the diff viewer. This makes it easy to see errors inline with the code and without having to open CI logs. Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
force-pushed
the
ruff-ci-matcher
branch
from
54af854 to
56c1c54
Compare
DarkLight1337
approved these changes
Oct 19, 2024
github-actions
bot
added
the
ready
charlifu
pushed a commit
to charlifu/vllm
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: charlifu <charlifu@amd.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Alvant <alvasian@yandex.ru>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: qishuai <ferdinandzhong@gmail.com>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
56c1c54 [CI/Build] Tell ruff to generate github formatted errors
commit 56c1c54
Author: Russell Bryant rbryant@redhat.com
Date: Fri Oct 18 19:27:31 2024 +0000
Sample display of an error: