Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(v3)：remove context evaluation #197

Closed
wants to merge 1 commit into from
Closed

fix(v3)：remove context evaluation #197

wants to merge 1 commit into from

Conversation

FitzBogard
Copy link

No description provided.

@FitzBogard FitzBogard changed the title fix：remove context evaluation fix(v3)：remove context evaluation Aug 9, 2023
@FitzBogard
Copy link
Author

#196

@FitzBogard FitzBogard closed this by deleting the head repository Mar 18, 2024
@philippgille
Copy link

I don't think removing that line is enough, because the msg.Ctx is not serialized, so not propagated through Redis, so it would be empty in the worker:

taskq/message.go

Line 23 in 2ba5e80

Ctx context.Context `msgpack:"-"`

But haven't tested.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FitzBogard @philippgille