Flush buffers before reading back in to construct all seen addresses #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timpalpant
force-pushed
the
flush-buffers
branch
from
0fed47e
to
7dd16b6
Compare
timpalpant
force-pushed
the
flush-buffers
branch
from
7dd16b6
to
79551b1
Compare
|
Could you add a test that hits the new code? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling profiling, the log of samples written is read back in by
LogReaderDumpNativeto construct a deduplicated set of all code addresses that were recorded during sampling. This set is then passed to_vmprof.write_all_code_objectsto write out the address and file/symbol info.However if the last call to
commit_bufferis a short write (for example because it was interrupted by a signal), then the LogReader may not be able to parse the tail of the file because we may still have pending un-flushed buffers (see:_write_single_ready_buffer).This change adds a function to ensure all pending buffers are flushed to disk before attempting to reread them with the LogReader.