implement and use resolve_many_addr #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it uses _vmprof.resolve_many_addr on pypy, which is *much* more efficient
|
Maybe solves #226 if implemented for CPython Edit: added qualifier |
|
I'm not sure I would want to take on the responsibility of doing this for CPython as well :-(. But yes, it might make things faster in theory |
|
Hmm. were tests broken before this PR? Something seems off in tests. |
mattip
reviewed
Feb 11, 2025
|
I have fixed the problem of pypy3.10 in the pypy repo. should we add some code in vmprof to deal with the wrong types? |
|
Let's wait for the bugfix release |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it uses the soon-to-be merged
_vmprof.resolve_many_addron pypy, which is much more efficient. marking as draft until the pypy PR lands.