Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Skylight performance improvement - Investigate to reduce disk-attach wait time in the Windows plugin #1780

Closed
venilnoronha opened this issue Aug 18, 2017 · 3 comments · Fixed by #1991

Comments

@venilnoronha
Copy link
Contributor

venilnoronha commented Aug 18, 2017

The fs.maxDiskAttachWaitSec is set to 60 seconds to prevent failures during parallel volume requests, as access to the powershell utility is synchronized. This should be reduced once parallel disk identification is implemented. Currently, fs.getDiskNum(..) blocks during parallel execution due to synchronized access to ps.Exec(..). Therefore, parallel volume creation in e2e tests block in fs.DevAttachWait(..) for a while and so we allow a long delay here.

See #1775 and these lines for more information.

/cc @shaominchen

@tusharnt
Copy link
Contributor

@shaominchen , @pshahzeb Can you please add the perf numbers after @venilnoronha's change went in.

@shaominchen
Copy link
Contributor

We are putting 2 days for investigation of this issue. Will file separate issues if parallel execution can be achieved.

@shaominchen shaominchen changed the title Reduce disk-attach wait time in the Windows plugin Investigate to reduce disk-attach wait time in the Windows plugin Sep 13, 2017
@shuklanirdesh82
Copy link
Contributor

We are putting 2 days for investigation of this issue. Will file separate issues if parallel execution can be achieved.

mustfix for atleast investigation task (adding mustfix and investigate keywords)

@tusharnt tusharnt changed the title Investigate to reduce disk-attach wait time in the Windows plugin Skylight performance improvement - Investigate to reduce disk-attach wait time in the Windows plugin Oct 2, 2017
@shuklanirdesh82 shuklanirdesh82 modified the milestones: Sprint - Spiderman, Sprint - Superman Oct 10, 2017
shuklanirdesh82 added a commit to shuklanirdesh82/vsphere-storage-for-docker that referenced this issue Nov 16, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.