This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Minor test improvements #1100
Merged
Minor test improvements #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 28, 2017 10:00
added 2 commits
March 28, 2017 12:20
pdhamdhere
changed the title
shuklanirdesh82
approved these changes
Mar 29, 2017
| @@ -250,6 +253,9 @@ func TestSanity(t *testing.T) { | |||
| volumeName, elem.endPoint) | |||
| } | |||
| } | |||
| fmt.Printf("%s END: Running TestSanity on %s (may take a while)...\n", | |||
There was a problem hiding this comment.
minor: better to stick with other logging in this file using t.Logf() ... e.g. line 252
IIRC, you were suggesting to use log as it comes with in-built logging current time.
There was a problem hiding this comment.
True but I am trying to be consistent with START block at L213 'fmt.Printf("%s START:'
There was a problem hiding this comment.
I see ... fine with me. We will take care during massive cleanup.
Great! Thanks for helping here! |
|
Thanks @shuklanirdesh82 for review. Since this is test-only minor change, merging with 1 approval. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves approximately 8-9minutes each CI run.