This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Improving error message incase of version mismatch between client and server(#1103) #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msterin
reviewed
Aug 4, 2017
esx_service/vmdk_ops.py
Outdated
| reply_string = err("vSphere Docker Volume Service client version ({}) is newer than server version ({}), " | ||
| "please update the server.".format(client_protocol_version, SERVER_PROTOCOL_VERSION)) | ||
| reply_string = err("There is a mismatch between vDVS client version ({}) and server version ({}), " | ||
| "please make sure vDVS plugin and driver are from the same release version.".format(client_protocol_version, SERVER_PROTOCOL_VERSION)) |
There was a problem hiding this comment.
as far as I recall these are not versions of the product but rather versions of communication protocol.
To avoid confusion with versions (e.g 0.16)I think it's better to say There is a mismatch between vDVS client (Docker plugin) protocol version and server (ESXi) protocol versionm which indicates that different versions of the product are installed on Guest and ESXi sides. Please make sure....
There was a problem hiding this comment.
Yeah it is communication protocol version. Sure I will improve this in the next diff.
Thanks!
There was a problem hiding this comment.
root@sc-rdops-vm18-dhcp-57-89:~# docker volume create -d vsphere p3
Error response from daemon: create p3: VolumeDriver.Create: There is a mismatch between vDVS client (Docker plugin) protocol version
(2) and server (ESXi) protocol version (3) which indicates different
versions of the product are installed on Guest and ESXi sides,
please make sure vDVS plugin and driver are from the same release version.
root@sc-rdops-vm18-dhcp-57-89:~#
shuklanirdesh82
force-pushed
the
protolMismatchError.shuklanirdesh82
branch
from
cd4b6cc
to
481d4d2
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103
Please refer #1103 (comment)
Testing done: Yes locally (by changing version)