This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Only process requests from clients with privilege #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to bind a port below 1024 on the client side, the plugin needs to be run as root or given neccessary privileges. This change enforces the policy of only allowing privileged clients. To keep things simple the client port to bind is the same as the server. Testing: 1. Install client without code change to use priviledge port 2. Validate that docker requests fail and log messages are generated. 3. Upgrade to client with code change for priviledge port 4. Validate that docker requests pass Will be filling a separate issue to resolve the std out logging on ESX. We need to invest a bit more to override the std out buffer and redirect it to a log file.
|
fixes #436 |
|
Thanks for the fix. LGTM (contingent on CI passing) |
|
LGTM |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to bind a port below 1024 on the client side, the plugin
needs to be run as root or given neccessary privileges. This change
enforces the policy of only allowing privileged clients.
To keep things simple the client port to bind is the same as the server.
Testing:
Will be filling a separate issue to resolve the std out logging
on ESX. We need to invest a bit more to override the std out buffer
and redirect it to a log file.