This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Link VIB version to the build version. #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
force-pushed
the
vibversions.kerneltime
branch
from
October 6, 2016 19:31
35684a9
to
8edf1ad
Compare
What's the output of |
|
kerneltime
force-pushed
the
vibversions.kerneltime
branch
from
October 6, 2016 20:20
8edf1ad
to
aa9417b
Compare
msterin
approved these changes
Oct 6, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - only one nit about comment :-)
@@ -27,7 +27,14 @@ PYLINT := /usr/bin/pylint | |||
BIN := ../build | |||
|
|||
# VIB version is either set from outside, or includes git commit SHA | |||
PKG_VERSION ?= 0.1.TP-pre.$(shell git log --pretty=format:'%h' -n 1) | |||
PKG_VERSION ?= $(shell \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would be nice to add a resulting format (example) to comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
kerneltime
force-pushed
the
vibversions.kerneltime
branch
from
October 6, 2016 20:31
aa9417b
to
2afe455
Compare
The vib version was not being set for each build or release. As per documentation an additional release version is added. ``` Versioning VIBs Because VIBs are intended to allow the ESXi installer to handle updates as well as initial installs, it is important to use the versioning variables in the VIB correctly. The package version can have a length of up to 35 characters. It includes the version number, immediately followed by a hyphen (‐) followed by the release version, as in the following example: 5.0.0-1.0vmw Both the version number and the release version number consist of one or more characters in the set [a‐a‐Z0‐9], with periods separating two or more groups. ``` Testing: Make vib and install. Run command ```esxcli software profile get``` Output: ``` (Original Vendor):VMware, Inc. 2016-07-06T10:45:12.595760+00:00: The following VIBs are installed: esx-vmdkops-service 0.7.14b2727-0.0.1 ```
kerneltime
force-pushed
the
vibversions.kerneltime
branch
from
October 6, 2016 20:32
2afe455
to
c965618
Compare
LGTM |
msterin
approved these changes
Oct 6, 2016
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vib version was not being set for each build or release.
As per documentation an additional release version is added.
Testing:
Make vib and install.
Run command
esxcli software profile get
Output: