Add photon volumes to volume plugin #811
Conversation
|
This PR should also includes updates for demos that are online. |
govint
force-pushed
the
add-photon
branch
2 times, most recently
from
fe6adb0
to
450c168
Compare
There was a problem hiding this comment.
Since it's a replica of #798 I've only skimmed the code. One nit, and one request - would it be possible to have a distinct commit for "adding photon files to vendor folder" so it does not interfere with content of the actual code change ?
| sleepBeforeMount = 1 * time.Second | ||
| watchPath = "/dev/disk/by-path" | ||
| version = "VMDK Volume Driver v0.3" |
There was a problem hiding this comment.
version is long overdue for clicking up. I suggest 1.3 :-)
There was a problem hiding this comment.
The value checked in should be irrelevant.
We need to set this from the make file similar to how we patch the vib xml.
This is important for tagged releases.
There was a problem hiding this comment.
@kerneltime, is it a make generated go file with the version in it and it gets compiled along with the driver?
There was a problem hiding this comment.
To do it properly would be more involved, but looking at the code, why do we need this field? This is not the same as a RPC version which can be something checked in and tracked in code. This field can be dropped.
There was a problem hiding this comment.
Assuming we don't have a problem with having a version string logged and returned by the driver, we can do it via the build vs. hardcoding it here.
Actually, the driver version is pretty much the plugin version itself, which is why its there (may not be displayed).
There was a problem hiding this comment.
I am not sure I follow. We install a plugin on the client, the plugin binary itself could be tagged with a prefix and symlinked to the binary name that is used. I think we should remove this const here and move to tracking version of the binary via the packaging scheme. This is how i t works for vib as well. For the RPC between the ESX server and client we can hard code the version and change it when needed.
If we do decide to keep it we should leverage https://golang.org/cmd/link/
govint
force-pushed
the
add-photon
branch
2 times, most recently
from
1fed55c
to
feeccb3
Compare
| [TOC] | ||
| The Docker volume plugin supports the below platforms and the corresponding drivers for those. The plugin supports all volume provisioning and managenment operations, defined by the Docker Volume plugin interface, on both platforms. | ||
|
|
||
| 1. Vmdk |
There was a problem hiding this comment.
Are we going to add/replace driver name to `vSphere'
There was a problem hiding this comment.
I've raised a separate issue to rename to "vsphere".
This PR is a new version of #798. The old PR had to be closed as the branch used had to be deleted and remade.