Skip to content

Commit

Permalink
fix(datagrid): use outline token for cell focus (#1467)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Focus outline for datagrid cells is not visible in firefox browser.

Issue Number: CDE-2124

## What is the new behavior?
Using object interaction outline token to show the focus for all
browsers.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
  • Loading branch information
valentin-mladenov authored Jul 2, 2024
1 parent 1310e28 commit 0be3dd4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions projects/angular/src/data/datagrid/_datagrid.clarity.scss
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,8 @@
border: none;

&:focus {
outline: -webkit-focus-ring-color solid tokens.$cds-global-space-2;
outline: tokens.$cds-alias-object-interaction-outline;
outline-color: -webkit-focus-ring-color;
outline-offset: calc(-1 * tokens.$cds-global-space-2);
}

Expand Down Expand Up @@ -640,7 +641,8 @@
}

&:focus {
outline: -webkit-focus-ring-color solid tokens.$cds-global-space-2;
outline: tokens.$cds-alias-object-interaction-outline;
outline-color: -webkit-focus-ring-color;
outline-offset: calc(-1 * tokens.$cds-global-space-2);
}

Expand Down

0 comments on commit 0be3dd4

Please # to comment.