Skip to content

Commit

Permalink
fix(tokens): add new global blue 25 and update alias colors (#1555)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?


- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
Light Theme:
- Token `--cds-alias-utility-gray` is using
`--cds-global-contruction-500`.

Issue Number: CDE-2297, CDE-2312

## What is the new behavior?
Temp overrides
Light Theme:
- Token `--cds-alias-utility-gray` is using
`--cds-global-contruction-600`.

Other:
- Token `--cds-global-color-blue-25` added with `hsl(198, 100%, 96%)`
value.


## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

---------

Co-authored-by: GitHub <noreply@github.com>
  • Loading branch information
valentin-mladenov and web-flow authored Oct 9, 2024
1 parent a51d2d8 commit ccf1236
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions projects/ui/src/temp-overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
*/
@use '@cds/core/tokens/tokens.scss';
[cds-theme] {
--cds-global-color-blue-25: hsl(198, 100%, 96%);

--cds-alias-utility-gray: #{tokens.$cds-global-color-construction-600};

--cds-alias-object-container-backdrop-background: hsla(0, 0%, 100%, 0.6);
--cds-alias-object-interaction-background-hover: #{tokens.$cds-global-color-construction-50};
--cds-alias-object-interaction-background-active: #{tokens.$cds-global-color-construction-100};
Expand All @@ -28,6 +32,8 @@
}

[cds-theme~='dark'] {
--cds-alias-utility-gray: #{tokens.$cds-global-color-construction-300};

--cds-alias-object-container-backdrop-background: #{tokens.$cds-alias-object-opacity-300};
--cds-alias-object-interaction-background-hover: #{tokens.$cds-global-color-construction-800};
--cds-alias-object-interaction-background-active: #{tokens.$cds-global-color-construction-600};
Expand Down
Binary file modified tests/snapshots/chromium/badge/badge--initial-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/chromium/label/label--label-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/chromium/label/label--showcase-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/badge/badge--initial-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/label/label--label-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/snapshots/firefox/label/label--showcase-core-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit ccf1236

Please # to comment.