Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(tooltip): text color of nested list #1522

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

list HTML element have wrong text color in tooltip component.

Issue Number: CDE-1700

What is the new behavior?

list HTML element have correct text color in tooltip component.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team August 27, 2024 13:31
@valentin-mladenov valentin-mladenov marked this pull request as ready for review August 27, 2024 13:32
@valentin-mladenov valentin-mladenov self-assigned this Aug 27, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@LynxDelli
Copy link
Contributor

LGTM

@valentin-mladenov valentin-mladenov merged commit 3ccaf28 into main Aug 30, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the list-in-tooltip-textcolor_cde-1700 branch August 30, 2024 05:50
valentin-mladenov added a commit that referenced this pull request Aug 30, 2024
Backport of 3ccaf28 from (#1522) to 16.x.
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
`list` HTML element have wrong text color in `tooltip` component.

Issue Number: CDE-1700

## What is the new behavior?
`list` HTML element have correct text color in `tooltip` component.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants