Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(datagrid): align action items focus/hover/selected with dropdown #1690

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Jan 29, 2025

Use the same styles as dropdown items for datagrid action items. This results in focus being indicated with an outline instead of focus and hover using the same background color.

CDE-2565

@kevinbuhmann kevinbuhmann requested a review from a team January 29, 2025 17:09
@kevinbuhmann kevinbuhmann self-assigned this Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/datagrid-action-selected branch from 1eac31b to 3280828 Compare January 29, 2025 17:10
Copy link
Contributor

@dtsanevmw dtsanevmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should sync with design as there is no specification in Figma but I think we should have hover, :active, :focus, plus the additional states that we have on other components of this type if we count focus as selected ( selected-hover, selected-active ). Currently if you click on element with the mouse you are not getting to an :active state and it directly gets the focus / selected color and it get closed.

I see there is .active class there but not sure when this is activated.

@kevinbuhmann kevinbuhmann marked this pull request as draft January 30, 2025 16:07
@kevinbuhmann kevinbuhmann force-pushed the kevin/datagrid-action-selected branch from 3280828 to e06b7c1 Compare January 30, 2025 16:16
@kevinbuhmann kevinbuhmann changed the title fix(datagrid): use selected background color for action items fix(datagrid): align action items focus/hover/selected with dropdown Jan 30, 2025
@kevinbuhmann kevinbuhmann force-pushed the kevin/datagrid-action-selected branch from e06b7c1 to 209b93c Compare January 30, 2025 16:21
@kevinbuhmann kevinbuhmann marked this pull request as ready for review January 30, 2025 16:21
@kevinbuhmann kevinbuhmann merged commit 31bb1c2 into main Jan 31, 2025
12 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/datagrid-action-selected branch January 31, 2025 18:51
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants