Improve content synchronization #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
|
Hi and sorry for the extremely delayed response. Your PR and all submissions to this project are very much appreciated. I am just doing a quick review and then will look to merge. Thank you again for your contributions. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes reduces mailspam when updating pages and attachments in Confluence.
Without the
minorEditparameter every change creates a mail for all watchers. The default is now changed to useminorEdit=Trueand thus not create notification mails. The previous behaviour can be restored by using the new cli option--no-minoredit.Another implemented optimization is focused on attachments. The previous implementation was syncing all attachments everytime. When a page has a lot of attachments, this quickly creates many versions and wastes storage. The optimization uses the comment field to store a hash of the uploaded file and only re-uploads the contetns, if the hash of the current file does not match the one stored in comment. This behaviour can also be disabled by specifying
--no-optimizeattachments.