add darwin arm64 build target, improve m1 devx

[joefitzgerald]

Signed-off-by: Joe Fitzgerald jfitzgerald@vmware.com

What this PR does / why we need it

This PR causes darwin / arm64 binaries to be generated by make release. It also makes improvements to scripts that support building a release locally on an arm64 Mac.

Details for the Release Notes

generate arm64 binaries for darwin

Which issue(s) this PR fixes

N/A

Describe testing done for PR

• ran make release locally and validated it succeeds

Special notes for your reviewer

• This PR will be accompanied with a cayman_vmware-tanzu_tce MR to ensure the new binaries are notarized correctly.

[davidvonthenen]

I left a comment... and I'm going to private message you about the signing process.

[davidvonthenen]

This looks good to me!

[davidvonthenen]

The build failure is being fixed right now... we just need to add the platform ENV to tanzu cli as an environment variable that it should pass. we talked about it and it should be happening any second now.

this looks great!!!!!! 🎆

[nrb]

#1158 will also touch on this.

[joefitzgerald]

Rebased on main, updated the PR to take advantage of changes in #1158.

[davidvonthenen]

We need to hold merging this PR after it was switched from curl to go install. A number of the pre-baked runner and jenkins OVAs don't have a go env. Will need to add one. I need to see about reprioritizing updating those images to support this.

[davidvonthenen]

Please see comment above. This PR is good but I have work on the build infra side to support this.

EDIT: Going to try to do this week.

[joefitzgerald]

@dvonthenen I updated the PR to also copy the go install-ed binaries to /usr/local/bin. This should obviate the need for adding $GOPATH/bin to the path on the runners.

The above assumes that go itself is installed, given that these machines build go code. No explicit go environment needs to be set up; there is a default $GOPATH when none is set in the environment, and $GOPATH/bin is automatically created by the go tool if it does not exist when running go install.

Also please note that the use of go install is limited to Darwin. Linux is unmodified and uses curl.

[nrb]

@joefitzgerald Are you able to build the tanzu binary with this?

I ask because the tanzu-framework Makefile defines a small subset of environments, and it's checked such that it shouldn't compile.

I did a search for PRs on tanzu-framework but couldn't find any.

[stmcginnis]

Tanzu framework will warn on building it since it's not in the "standard" set of target platforms yet, but it will actually build. I tested it a few months ago and it builds and the CLI runs fine. The issues were actually trying to deploy a management cluster where things failed completely.

[davidvonthenen]

LGTM. thanks for this awesome contribution!

all unresolved issues have been addressed