Helm Charts: Ability to opt out from namespace creation #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving the helm charts the ability to create namespaces might not be acceptable in certain situations, especially when you (as the cluster admin) want to have a tighter control around resource quotas. This PR gives the helm chart ability to opt-out automatic namespace creation. -- When that happens, the operator will have to manually create vsecm-system, spire-system, and spire-server namespaces. Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the helm charts the ability to opt-out from creating
spire-server,spire-systemandvsecm-systemnamespace.If the the namespace-creation is opted-out, then the operator will need to manually create these namespaces before installing the helm chart.