Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update blog navigation #235

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Update blog navigation #235

merged 13 commits into from
Sep 1, 2023

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Aug 31, 2023

Updates to the blog navigation to make it easier to browse.

Also, changed the homepage to fetch the blog contents dynamically instead of writing and collating them by hand.

v0lkan added 2 commits August 29, 2023 10:26
@v0lkan
small changes
7215976 
small changes

Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan
modifications in blog navigation
4c96d89 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan v0lkan requested a review from RamXX as a code owner August 31, 2023 05:55
@v0lkan
whitespace
401802b 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
v0lkan added 3 commits August 30, 2023 22:59
@v0lkan
whitespace
5c035ec 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan
whitespace
6e1e9a6 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan
whitespace
070984f 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
@v0lkan
whitespace
0f68867 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
abhishek44sharma
abhishek44sharma reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@abhishek44sharma abhishek44sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in blog.md, rest looks good.

docs/_pages/0005-blog.md Show resolved Hide resolved
@vmwclabot
Copy link

@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@v0lkan, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@abhishek44sharma abhishek44sharma self-requested a review September 1, 2023 19:47
abhishek44sharma
abhishek44sharma approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@abhishek44sharma abhishek44sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@v0lkan
Copy link
Contributor Author

v0lkan commented Sep 1, 2023

Looks like there is some issue with my git tooling about signing commits.

I’ll squash all the commits, assuming a single commit in the main source line signed off by me would make the bot happy.

Will pay more attention to this next time.

@v0lkan v0lkan merged commit b35cb5b into main Sep 1, 2023
@v0lkan v0lkan deleted the feature/blog-template branch September 1, 2023 20:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@abhishek44sharma abhishek44sharma abhishek44sharma approved these changes

@ats0stv ats0stv Awaiting requested review from ats0stv

@RamXX RamXX Awaiting requested review from RamXX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v0lkan @vmwclabot @abhishek44sharma