Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

minor fixes #273

Merged
merged 1 commit into from
Sep 19, 2023
Merged

minor fixes #273

merged 1 commit into from
Sep 19, 2023

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Sep 19, 2023

No description provided.

@v0lkan
minor fixes
163a32b 
Signed-off-by: Volkan Özçelik <ovolkan@vmware.com>
abhishek44sharma
abhishek44sharma approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@abhishek44sharma abhishek44sharma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
only one comment, if we've scenario to get system namespace multiple time it's better to cache rather than making Getenv() calls. But we'll see when the scenario occurs. looks good to me for now!! 👍

@abhishek44sharma abhishek44sharma merged commit 8f69c9f into main Sep 19, 2023
@abhishek44sharma abhishek44sharma deleted the ovolkan/minor-fixes branch September 19, 2023 05:27
@abhishek44sharma abhishek44sharma mentioned this pull request Sep 19, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@abhishek44sharma abhishek44sharma abhishek44sharma approved these changes

@farhan-pasha farhan-pasha Awaiting requested review from farhan-pasha

@ats0stv ats0stv Awaiting requested review from ats0stv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v0lkan @abhishek44sharma