documentation updates and some minor refactoring #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0lkan
commented
Oct 4, 2023
| // | ||
| // The function uses the crypto/rand package for secure random number | ||
| // generation, suitable for cryptographic purposes. | ||
| func generateAesSeed() (string, error) { |
There was a problem hiding this comment.
moved it to a separate file.
v0lkan
commented
Oct 4, 2023
Comment on lines
+22
to
+26
| <p>The next <strong><a href="/docs/contributor-sync/" | ||
| style="text-decoration: underline; color: #0946EC" | ||
| >VSecM Contributor Sync</a></strong> will be on…<br> | ||
| <strong>Thursday, 2023-10-26</strong> | ||
| at <strong>8:00am</strong> Pacific time.</p> |
There was a problem hiding this comment.
Filed an issue to dynamically generate these (from a source of truth) instead of creating a PR whenever something new is announced.
It’s not urgent, though; we can live this way for a while.
v0lkan
commented
Oct 4, 2023
Comment on lines
+53
to
+60
| ### VMware Secrets Manager Contributor Sync — 2023-09-29 | ||
|
|
||
| <div style="padding:56.25% 0 0 0;position:relative;"><iframe | ||
| src="https://player.vimeo.com/video/869636733?badge=0&autopause=0&player_id=0&app_id=58479" | ||
| frameborder="0" allow="autoplay; fullscreen; picture-in-picture" | ||
| style="position:absolute;top:0;left:0;width:100%;height:100%;" | ||
| title="VMware Secrets Manager Contributor Sync — 2023-09-29" | ||
| ></iframe></div><script src="https://player.vimeo.com/api/player.js"></script> |
There was a problem hiding this comment.
added the VOD of last session.
v0lkan
commented
Oct 4, 2023
Comment on lines
+570
to
+574
| echo "Running Go unit tests..." | ||
| if ! go test ./...; then | ||
| echo "Go unit tests failed, exiting." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Runs unit tests before every integration test.
If unit tests are failing, there is no reason to run integration tests which are more expensive to run.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.