Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Introducing initial helm-chart for version 0.21.5 #344

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Introducing initial helm-chart for version 0.21.5 #344

merged 2 commits into from
Dec 17, 2023

Conversation

abhishek44sharma
Copy link
Contributor

No description provided.

@abhishek44sharma
Introducing initial helm-chart for version 0.21.5
94dcef5 
Signed-off-by: Abhishek Sharma <abhishek44sharma@gmail.com>
@abhishek44sharma abhishek44sharma self-assigned this Dec 5, 2023
v0lkan
v0lkan approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, as far as yamls go :).

v0lkan
v0lkan requested changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had some change requests and questions.

helm-charts/0.21.5/values.yaml Show resolved Hide resolved
helm-charts/0.21.5/values.yaml Show resolved Hide resolved
helm-charts/0.21.5/values.yaml Outdated Show resolved Hide resolved
helm-charts/0.21.5/values.yaml Outdated Show resolved Hide resolved
helm-charts/0.21.5/values.yaml Show resolved Hide resolved
v0lkan
v0lkan approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 .

@abhishek44sharma
Fixing review comments
3e32978 
Signed-off-by: Abhishek Sharma <abhishek44sharma@gmail.com>
@abhishek44sharma abhishek44sharma merged commit 85b7d5d into main Dec 17, 2023
2 checks passed
@abhishek44sharma abhishek44sharma deleted the initializing-helm-chart/0.21.5 branch December 17, 2023 17:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@v0lkan v0lkan v0lkan approved these changes

@farhan-pasha farhan-pasha Awaiting requested review from farhan-pasha

Assignees

@abhishek44sharma abhishek44sharma

Labels
feature:helm-charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishek44sharma @v0lkan