Fix flaky package plugin tests

cmd/cli/plugin/package/test/package_plugin_integration_test.go

@@ -488,37 +488,37 @@ func setUpPrivateRegistry(kubeconfigPath, clusterName string) {
 		}
 	}
 
-	By("make sure package API is available after kapp-controller restart")
+	By("make sure registry pod is running")
 	err = retry.OnError(
 		backOff,
 		func(err error) bool {
 			return err != nil
 		},
 		func() error {
-			result = packagePlugin.ListRepository(&repoOptions)
-			if result.Error != nil {
-				return result.Error
+			podList, err := clientSet.CoreV1().Pods(registryNamespace).List(context.Background(), metav1.ListOptions{})
+			if err != nil {
+				return err
+			}
+
+			for _, pod := range podList.Items {
+				if pod.Status.Phase != corev1.PodRunning {
+					return errors.New("registry pod is not running")
+				}
 			}
 			return nil
 		})
 	Expect(err).ToNot(HaveOccurred())
 
-	By("make sure registry pod is running")
+	By("make sure package API is available after kapp-controller restart")
 	err = retry.OnError(
 		backOff,
 		func(err error) bool {
 			return err != nil
 		},
 		func() error {
-			podList, err := clientSet.CoreV1().Pods(registryNamespace).List(context.Background(), metav1.ListOptions{})
-			if err != nil {
-				return err
-			}
-
-			for _, pod := range podList.Items {
-				if pod.Status.Phase != corev1.PodRunning {
-					return errors.New("registry pod is not running")
-				}
+			result = packagePlugin.ListRepository(&repoOptions)
+			if result.Error != nil {
+				return result.Error
 			}
 			return nil
 		})