Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Commit

Permalink
Default deploy-in-cluster-ipam-provider to true
Browse files Browse the repository at this point in the history
- Enabled deploy in-cluster ipam provider feature flag by default and
  remove the beta suffix.

Co-authored-by: Christian Ang <angc@vmware.com>
  • Loading branch information
flawedmatrix and christianang committed Dec 13, 2022
1 parent aa53317 commit c3dc0f4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
15 changes: 8 additions & 7 deletions cmd/cli/plugin/managementcluster/featureflags.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ import (
// DefaultFeatureFlagsForManagementClusterPlugin is used to populate default feature-flags for the management-cluster plugin
var (
DefaultFeatureFlagsForManagementClusterPlugin = map[string]bool{
"features.management-cluster.import": false,
"features.management-cluster.export-from-confirm": true,
"features.management-cluster.standalone-cluster-mode": false,
constants.FeatureFlagManagementClusterDualStackIPv4Primary: false,
constants.FeatureFlagManagementClusterDualStackIPv6Primary: false,
constants.FeatureFlagManagementClusterCustomNameservers: false,
constants.FeatureFlagAwsInstanceTypesExcludeArm: true,
"features.management-cluster.import": false,
"features.management-cluster.export-from-confirm": true,
"features.management-cluster.standalone-cluster-mode": false,
constants.FeatureFlagManagementClusterDualStackIPv4Primary: false,
constants.FeatureFlagManagementClusterDualStackIPv6Primary: false,
constants.FeatureFlagManagementClusterCustomNameservers: false,
constants.FeatureFlagAwsInstanceTypesExcludeArm: true,
constants.FeatureFlagManagementClusterDeployInClusterIPAMProvider: true,
}
)
2 changes: 1 addition & 1 deletion tkg/constants/featureflags.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const (
// FeatureFlagManagementClusterDeployInClusterIPAMProvider feature flag
// determines whether to apply the In-Cluster IPAM provider to the
// management cluster.
FeatureFlagManagementClusterDeployInClusterIPAMProvider = "features.management-cluster.deploy-in-cluster-ipam-provider-beta"
FeatureFlagManagementClusterDeployInClusterIPAMProvider = "features.management-cluster.deploy-in-cluster-ipam-provider"
// FeatureFlagAllowLegacyCluster is used to decide the workload cluster is clusterclass based or legayc based.
// By default, it's false. If it's true, then workload cluster is legacy based.
FeatureFlagAllowLegacyCluster = "features.cluster.allow-legacy-cluster"
Expand Down

0 comments on commit c3dc0f4

Please # to comment.