Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Refactor cli/core to fix linter issues #3470

Open
saji-pivotal opened this issue Sep 22, 2022 · 1 comment
Open

Refactor cli/core to fix linter issues #3470

saji-pivotal opened this issue Sep 22, 2022 · 1 comment
Assignees
Labels
area/testing CI kind/bug PR/Issue related to a bug

Comments

@saji-pivotal
Copy link
Contributor

Bug description
The following linters are failing in the cli/core module. They have been skipped for now, but the code needs to be refactored and tested in order to fully fix the linters

pkg/cli/catalog_test.go
pkg/cluster/client.go
pkg/command/config.go
pkg/command/doc.go
pkg/command/plugin_manager.go
pkg/command/root.go
pkg/command/update.go
pkg/config/bom.go
pkg/pluginmanager/manager.go

Affected product area (please put an X in all that apply)

  • ( ) APIs
  • ( ) Addons
  • (X) CLI
  • ( ) Docs
  • ( ) IAM
  • ( ) Installation
  • ( ) Plugin
  • ( ) Security
  • (X) Test and Release
  • () User Experience
  • (X) Developer Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

@saji-pivotal saji-pivotal added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Sep 22, 2022
@vuil vuil added CI area/testing and removed needs-triage Indicates an issue or PR needs to be triaged labels Oct 7, 2022
@vuil
Copy link
Contributor

vuil commented Oct 7, 2022

@saji-pivotal can this be closed?

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/testing CI kind/bug PR/Issue related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants