This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Reverting tools dependency to v0.1.10 #3433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3433 +/- ##
==========================================
- Coverage 53.99% 53.72% -0.27%
==========================================
Files 91 91
Lines 10006 10006
==========================================
- Hits 5403 5376 -27
- Misses 4169 4190 +21
- Partials 434 440 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
To see the full extent of the linter warnings, try applying this change to the toplevel Makefile temporarily to your PR:
|
6309912
to
255b907
Compare
This was referenced Sep 20, 2022
255b907
to
3d6ab51
Compare
e91bcf6
to
3ea9239
Compare
anujc25
reviewed
Sep 22, 2022
Sounds good. This PR looks to me. |
anujc25
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3ea9239
to
33d7dbe
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR attempts to fix linters getting short circuited because of an incompatible dependency version
This PR also fixes (or skips) linter issues in the following directories
Which issue(s) this PR fixes
Fixes #3438
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer