Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Refactor cli/runtime to fix linter issues #3471

Closed
saji-pivotal opened this issue Sep 22, 2022 · 0 comments · Fixed by #3612
Closed

Refactor cli/runtime to fix linter issues #3471

saji-pivotal opened this issue Sep 22, 2022 · 0 comments · Fixed by #3612
Assignees
Labels
area/testing CI kind/bug PR/Issue related to a bug

Comments

@saji-pivotal
Copy link
Contributor

Bug description
cli/runtime has linter issues which have been skipped for now. The code needs to be refactored to actually fix the linter issues
These are the following files that need to be refactored

apis/config/v1alpha/clientconfig.go
apis/config/v1alpha/clientconfig_types.go
component/prompt.go
config/conversion.go

Affected product area (please put an X in all that apply)

  • ( ) APIs
  • ( ) Addons
  • ( ) CLI
  • ( ) Docs
  • ( ) IAM
  • ( ) Installation
  • ( ) Plugin
  • ( ) Security
  • ( ) Test and Release
  • ( ) User Experience
  • ( ) Developer Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

@saji-pivotal saji-pivotal added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Sep 22, 2022
@vuil vuil removed the needs-triage Indicates an issue or PR needs to be triaged label Oct 7, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/testing CI kind/bug PR/Issue related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants