Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Tanzu CLI build targets should fail pessimistically/faster #3984

Open
jayunit100 opened this issue Nov 23, 2022 · 0 comments
Open

Tanzu CLI build targets should fail pessimistically/faster #3984

jayunit100 opened this issue Nov 23, 2022 · 0 comments

Comments

@jayunit100
Copy link
Contributor

jayunit100 commented Nov 23, 2022

Bug description

Am attempting to optimize the Tanzu-framework build w/ docker caching, but I hit this snag, where a bunch of artifacts dont seem to be there....

Tanzu CLI has 27 build steps... and make -C cliplugins docker-build can thus output LOTS of errors if a simple upstream build failure happened before...

  • tries to cd into 27 different directories:
    number of things in (login, management-cluster, package, pinnipied, secret, …, feature) = 9
  • 3 different OSs (linux, windows, os X)

You wind up getting a massive list of errors that are hard to understand

tanzu-framework/artifacts/linux/amd64/
cli/
ERROR cant CD to /#/v0.28.0-dev
ERROR cant CD to /management-cluster/v0.28.0-dev
ERROR cant CD to /package/v0.28.0-dev

and so on….
Two questions:

Can we “fail fast” for this build target so that the error is easier to interpret (i.e. oh, this failed cause of an upstream build target failing)….
Any hints on where i should look to fix this error ? It seems kinda self-referential

Expected behavior

Tanzu CLI should pessimistically fail quickly if can obvious missing directory / target isnt there, rather then failing 27 times for all OS/s. Maybe for example, first check for "plugins" or "login" or some other kind of quick make sanity task before running all 27 of the sub targets.

Steps to reproduce the bug

Run my current broken PR :) #3972

@jayunit100 jayunit100 added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Nov 23, 2022
@codegold79 codegold79 added area/cli area/plugin area/core-cli and removed needs-triage Indicates an issue or PR needs to be triaged labels Apr 5, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants