-
Notifications
You must be signed in to change notification settings - Fork 192
redo of BUILDKIT caching PR #3972
redo of BUILDKIT caching PR #3972
Conversation
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
|
||
# Build from publicly reachable source by default, but allow people to re-build images on | ||
# top of their own trusted images. | ||
ARG BUILDER_BASE_IMAGE=golang:1.18 | ||
|
||
ARG CACHE_GOBUILD=type=cache,target=/root/.cache/go-build | ||
ARG CACHE_GOLANG=cache,target=/root/.local/share/golang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARG CACHE_GOLANG=cache,target=/root/.local/share/golang | |
ARG CACHE_GOLANG=type=cache,target=/root/.local/share/golang |
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #3972 +/- ##
==========================================
- Coverage 49.51% 48.72% -0.79%
==========================================
Files 452 482 +30
Lines 44986 47164 +2178
==========================================
+ Hits 22273 22979 +706
- Misses 20588 22013 +1425
- Partials 2125 2172 +47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Cluster Generation A/B Results: |
rebasing this PR |
cc74399
to
ede3574
Compare
Cluster Generation A/B Results: |
ede3574
to
4f83805
Compare
Cluster Generation A/B Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* [DO NOT MERGE] WIP:redo of BUILDKIT caching PR * WIP: seeing if i can get tkr-source to compile * updated caches to use the old way * Cleanup and remove dbeugging * revert poller.go change, irrelevant * woudl typo fix
What this PR does / why we need it
fixes #2730
This is a "redo" of https://github.com/vmware-tanzu/tanzu-framework/pull/2731/files where @randomvariable originally did some caching.
Only differences, haven't tested...
$CACHE
Release Note