Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Refactor labels #1730

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

2022amanda
Copy link
Contributor

What this PR does / why we need it

Kickstart UI: refactor labels

Which issue(s) this PR fixes

Fixes #1620

Describe testing done for PR

Release note


PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

prkalle and others added 3 commits February 23, 2022 21:52
Add implmentation for tkr-infra-machine-webhook (vmware-tanzu#1638)

Signed-off-by: PremKumar Kalle <pkalle@vmware.com>

Review comments addressed

Signed-off-by: PremKumar Kalle <pkalle@vmware.com>

labels component

labelsMap

clusterlabelsValue

labelarray

labels
@2022amanda 2022amanda requested a review from a team as a code owner February 23, 2022 23:17
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1730/20220223232739/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@raymondz1
Copy link
Contributor

There is one css issue. The error message is wrapped.
Screen Shot 2022-02-24 at 3 30 35 PM

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kickstart UI: refactor labels
4 participants