Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

postNodeUpgrade won't upgrade standard-package-repo on tce (#1760) #1768

Closed
wants to merge 1 commit into from

Conversation

tenczar
Copy link
Contributor

@tenczar tenczar commented Mar 4, 2022

This change updates the upgradeAddonPostNodeUpgrade method to exclude
updating the standard-package-repo when the cluster is a TCE cluster.
The standard-package-repo does not exist on TCE clusters.

Co-authored-by: Nick Tenczar ntenczar@vmware.com

What this PR does / why we need it

Backport of PR 1760

Which issue(s) this PR fixes

Fixes #1749

Describe testing done for PR

I created a vSphere management cluster setting the build edition to TCE. I then ran management-cluster upgrade with log level nine. I confirmed in the logs that all of the required packages were upgraded and that the standard-package-repo was not upgrade.

Release note


PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

…nzu#1760)

This change updates the upgradeAddonPostNodeUpgrade method to exclude
updating the standard-package-repo when the cluster is a TCE cluster.
The standard-package-repo does not exist on TCE clusters.

Co-authored-by: Nick Tenczar <ntenczar@vmware.com>
@tenczar tenczar requested a review from a team as a code owner March 4, 2022 00:19
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/1768/20220304003355/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil vuil added the do-not-merge/hold Some fixes necessary, hold for merging label Mar 4, 2022
@tenczar tenczar closed this Mar 9, 2022
@tenczar
Copy link
Contributor Author

tenczar commented Mar 9, 2022

this has been cherry-picked to release-0.11

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required do-not-merge/hold Some fixes necessary, hold for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants