Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Consider additional metadata as part of kubernetes build version during version comparison #2289

Merged
merged 1 commit into from
May 3, 2022
Merged

Consider additional metadata as part of kubernetes build version during version comparison #2289

merged 1 commit into from
May 3, 2022

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented May 3, 2022 •
edited
Loading

What this PR does / why we need it

  • Consider additional metadata as part of kubernetes build version during version comparison
  • Example: Consider v1.17.3+vmware.1-fips.1 and v1.17.3+vmware.2-fips.1 comparison

Which issue(s) this PR fixes

Fixes #2292

Describe testing done for PR

  • Added unit tests

Release note

Consider additional metadata as part of kubernetes build version during version comparison

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested review from a team as code owners May 3, 2022 19:16
@github-actions
Copy link

github-actions bot commented May 3, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2289/20220503192708/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil vuil added area/lcm Related to Cluster Lifecycle management ok-to-merge PRs should be labelled with this before merging labels May 3, 2022
vuil
vuil approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anujc25 anujc25 force-pushed the update-k8sversion-verification branch from 4a38d87 to 3c8fbfc Compare May 3, 2022 20:20
@anujc25 anujc25 force-pushed the update-k8sversion-verification branch from 3c8fbfc to cebea65 Compare May 3, 2022 20:22
tenczar
tenczar approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented May 3, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2289/20220503203319/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented May 3, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2289/20220503203514/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

saji-pivotal
saji-pivotal approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@saji-pivotal saji-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anujc25 anujc25 merged commit a3ed62c into vmware-tanzu:main May 3, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@saji-pivotal saji-pivotal saji-pivotal approved these changes

@vuil vuil vuil approved these changes

@tenczar tenczar tenczar approved these changes

Assignees
No one assigned
Labels
area/lcm Related to Cluster Lifecycle management cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider additional metadata as part of kubernetes build version during version comparison
5 participants
@anujc25 @tenczar @vuil @saji-pivotal @vmwclabot