Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Adding tkr-status-controller to tkr-service package #2322

Merged

Conversation

saji-pivotal
Copy link
Contributor

@saji-pivotal saji-pivotal commented May 5, 2022

What this PR does / why we need it

Adds tkr-status controller to the tkr-service package

Which issue(s) this PR fixes

Fixes: Related to #1925

Describe testing done for PR

Manual testing

  1. Applied the tkr-status-controller deployment to an existing management-cluster
  2. Verified that the tkr-status-controller deployment was running as expected
  3. Tested locally by deploying the tkr-service package and all the components were successfully deployed

Release note

package-based-lcm: Adding tkr-status-controller to tkr-service package

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@saji-pivotal saji-pivotal requested review from a team as code owners May 5, 2022 22:39
@saji-pivotal saji-pivotal force-pushed the add-status-controller-package branch from a5e8791 to 6f12afa Compare May 5, 2022 23:58
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I would wait for @imikushin to look at it. Thanks

Copy link
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, LGTM.

With one question 🙂

@saji-pivotal saji-pivotal force-pushed the add-status-controller-package branch from 6f12afa to de0f3d0 Compare May 6, 2022 17:32
@saji-pivotal saji-pivotal force-pushed the add-status-controller-package branch from de0f3d0 to a3552d0 Compare May 9, 2022 18:12
@imikushin imikushin added the ok-to-merge PRs should be labelled with this before merging label May 10, 2022
@prkalle prkalle merged commit 6273ba8 into vmware-tanzu:main May 10, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants