Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

allow to customize healthz & webhook-server port #2354

Merged
merged 2 commits into from
May 19, 2022

Conversation

ggpaue
Copy link
Contributor

@ggpaue ggpaue commented May 11, 2022

What this PR does / why we need it

This PR is to allow customize healthz & webhook-server port in addons-manager

Which issue(s) this PR fixes

Fixes #2411

Describe testing done for PR

manually build addons-manager package and deploy to tanzu cluster to see if it can be reconciled successfully

Release note

package-based-lcm: Made healthz & webhook server port configurable in addons-manager package

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@ggpaue ggpaue requested review from a team as code owners May 11, 2022 23:50
@ggpaue ggpaue force-pushed the customizeHealthzPort branch from 67840fd to 95a3f68 Compare May 12, 2022 22:04
@ggpaue ggpaue requested review from vijaykatam and danniel1205 May 12, 2022 23:36
@ggpaue ggpaue force-pushed the customizeHealthzPort branch from 95a3f68 to 2bf59c4 Compare May 18, 2022 01:04
addons/main.go Outdated Show resolved Hide resolved
@vijaykatam vijaykatam added the ok-to-merge PRs should be labelled with this before merging label May 19, 2022
@ggpaue ggpaue merged commit 5cdba31 into vmware-tanzu:main May 19, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize healthz and webhook server port on addons manager package
4 participants