Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Adding scaffolding for the tkg-autoscaler package #2393

Merged

Conversation

saji-pivotal
Copy link
Contributor

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes ##2320

Describe testing done for PR

  • Created and published the autoscaler package to my personal registry
  • Created a management-cluster on AWS
  • Used tanzu package install to install the package from my personal registry to the AWS cluster
  • Verified that the autoscaler deployment was running

Release note

Adds scaffolding for the autoscaler package

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@saji-pivotal saji-pivotal requested a review from a team as a code owner May 16, 2022 23:53
@saji-pivotal saji-pivotal force-pushed the saji-autoscaler-package branch from 398744a to 0b9961f Compare May 18, 2022 04:59
@saji-pivotal saji-pivotal force-pushed the saji-autoscaler-package branch from 0b9961f to 782557c Compare May 25, 2022 22:49
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #2393 (417bc44) into main (4494221) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 417bc44 differs from pull request most recent head 2f8ad9a. Consider uploading reports for the commit 2f8ad9a to get more accurate results

@@            Coverage Diff             @@
##             main    #2393      +/-   ##
==========================================
+ Coverage   42.32%   42.38%   +0.05%     
==========================================
  Files         398      396       -2     
  Lines       39693    39026     -667     
==========================================
- Hits        16799    16540     -259     
+ Misses      21308    20943     -365     
+ Partials     1586     1543      -43     
Impacted Files Coverage Δ
...til/clusterbootstrapclone/clusterbootstrapclone.go 66.57% <0.00%> (-3.74%) ⬇️
...ons/controllers/packageinstallstatus_controller.go 80.57% <0.00%> (-0.07%) ⬇️
pkg/v1/webhooks/webhooks.go 0.00% <0.00%> (ø)
...ddons/webhooks/clusterbootstraptemplate_webhook.go
addons/webhooks/clusterbootstrap_webhook.go
addons/controllers/clusterbootstrap_controller.go 68.63% <0.00%> (+0.42%) ⬆️
addons/controllers/machine_controller.go 69.52% <0.00%> (+0.83%) ⬆️
pkg/v1/webhooks/certificates.go 8.40% <0.00%> (+1.20%) ⬆️
pkg/v1/util/patchset/patchset.go 100.00% <0.00%> (+3.57%) ⬆️
...g/v2/tkr/controller/tkr-source/pkgcr/reconciler.go 66.00% <0.00%> (+15.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4494221...2f8ad9a. Read the comment docs.

@saji-pivotal saji-pivotal force-pushed the saji-autoscaler-package branch from 782557c to 417bc44 Compare May 26, 2022 17:48
@saji-pivotal saji-pivotal requested review from a team as code owners May 26, 2022 17:48
@saji-pivotal saji-pivotal force-pushed the saji-autoscaler-package branch from 417bc44 to 6d34b0d Compare May 26, 2022 17:51
@saji-pivotal saji-pivotal force-pushed the saji-autoscaler-package branch 2 times, most recently from 333c76c to e368fc8 Compare June 3, 2022 21:48
@saji-pivotal saji-pivotal force-pushed the saji-autoscaler-package branch from e368fc8 to 2f8ad9a Compare June 3, 2022 22:07
@@ -0,0 +1,25 @@
# tkg-clusterclass-aws Package

This package provides << awesome functionality >> using [tkg-autoscaler](https://INFO_NEEDED).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< awesome functionality >>

I like this 😸

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we elaborate though? Even if it's very few concrete words, it'd still be better.

Copy link
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saji-pivotal !

@imikushin imikushin added the ok-to-merge PRs should be labelled with this before merging label Jun 4, 2022
@saji-pivotal saji-pivotal merged commit 41ba442 into vmware-tanzu:main Jun 4, 2022
ankeesler pushed a commit to ankeesler/tanzu-framework that referenced this pull request Jun 14, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/packages cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants