Bump cert-manager to 1.7.2 #2490

ridavid2002 · 2022-05-25T17:07:24Z

What this PR does / why we need it

Cert-manager needs to be bumped to a newer version. We are bumping version 1.5.3 (due to EOL) up to v1.7.2.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Created a sandbox build of 1.7.2 to ensure the component was compiled correctly. Will be doing additional tests and linking through the bolt tooling.

Release note

Bump cert-manager to v1.7.2.

PR Checklist

Squash the commits into one or a small number of logical commits
Use good commit messages
Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

…opic/certmanagerbump

github-actions · 2022-06-23T18:39:33Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220623183931/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-06-23T18:44:28Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220623184426/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-06-23T18:55:35Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220623185533/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-06-23T19:58:48Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220623195846/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

…opic/certmanagerbump

github-actions · 2022-06-27T13:34:59Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220627133457/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

…opic/certmanagerbump

github-actions · 2022-06-27T18:22:01Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220627182158/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

shyaamsn · 2022-07-12T11:55:39Z

@ridavid2002 I think the cert-manager test is failing since the certificate resource being applied is v1alpha2.

Could you please change v1alpha2 to v1 in https://github.com/vmware-tanzu/tanzu-framework/blob/main/pkg/v1/tkg/test/data/cert-manager-resources.yaml#L7 and https://github.com/vmware-tanzu/tanzu-framework/blob/main/pkg/v1/tkg/test/data/cert-manager-resources.yaml#L15

…opic/certmanagerbump

github-actions · 2022-07-12T13:29:33Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220712132930/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-07-12T13:30:32Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220712133030/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

…opic/certmanagerbump

github-actions · 2022-07-13T13:16:17Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220713131615/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

anujc25

It looks like CAPD integration tests are failing with this error:

• Failure [5.010 seconds]
Addon tests for capd clusters
/home/tanzu/actions-runner/_work/tanzu-framework/tanzu-framework/pkg/v1/tkg/test/tkgctl/docker/docker_addons_test.go:15
should verify cert-manager [It]
/home/tanzu/actions-runner/_work/tanzu-framework/tanzu-framework/pkg/v1/tkg/test/tkgctl/shared/addons.go:55
Unexpected error:
      <*meta.NoKindMatchError | 0xc000e7d680>: {
          GroupKind: {
              Group: "cert-manager.io",
              Kind: "Certificate",
          },
          SearchedVersions: ["v1alpha2"],
      }
      no matches for kind "Certificate" in version "cert-manager.io/v1alpha2"
  occurred
  /home/tanzu/actions-runner/_work/tanzu-framework/tanzu-framework/pkg/v1/tkg/test/tkgctl/shared/addons.go:119

This can be because of the change in API version

- apiVersion: cert-manager.io/v1alpha2
+ apiVersion: cert-manager.io/v1

(UPDATE: Just saw @shyaamsn mentioned the changes needed for this and has already been done as part of the PR. But looks like tests are still failing.)

pkg/v1/tkg/tkgconfigupdater/tkgconfigupdater_test.go

shyaamsn · 2022-07-14T00:25:52Z

@ridavid2002 Can you please change v1alpha2 to v1 here: https://github.com/vmware-tanzu/tanzu-framework/blob/main/pkg/v1/tkg/test/tkgctl/shared/addons.go#L113

github-actions · 2022-07-14T12:54:58Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220714125456/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

…opic/certmanagerbump

github-actions · 2022-07-14T16:56:13Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220714165611/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

github-actions · 2022-07-14T17:00:22Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220714170019/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

codecov · 2022-07-14T17:19:15Z

Codecov Report

Merging #2490 (5d56488) into main (8bd97cb) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
+ Coverage   43.97%   44.03%   +0.06%     
==========================================
  Files         416      416              
  Lines       41735    41735              
==========================================
+ Hits        18354    18380      +26     
+ Misses      21665    21645      -20     
+ Partials     1716     1710       -6

Impacted Files	Coverage Δ
addons/controllers/clusterbootstrap_controller.go	`65.57% <0.00%> (+2.29%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd97cb...5d56488. Read the comment docs.

anujc25

Looks good

…opic/certmanagerbump

github-actions · 2022-07-15T02:12:04Z

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2490/20220715021202/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

ridavid2002 · 2022-07-15T12:10:34Z

//usebom:sandbox/v1.6.0-zshippable/416614966292914236/tkg-compatibility

initial cert-manager 1.7.2 publish

3af6e20

ridavid2002 requested a review from a team as a code owner May 25, 2022 17:07

ridavid2002 self-assigned this May 25, 2022

ridavid2002 requested review from a team as code owners May 25, 2022 17:07

vmwclabot added the cla-not-required label May 25, 2022

ridavid2002 added 4 commits May 31, 2022 08:32

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

ef36a3d

…opic/certmanagerbump

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

a17d52c

…opic/certmanagerbump

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

991913e

…opic/certmanagerbump

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

adfa584

…opic/certmanagerbump

ridavid2002 added the do-not-merge/hold Some fixes necessary, hold for merging label Jun 21, 2022

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

82e9677

…opic/certmanagerbump

ridavid2002 added ok-to-merge PRs should be labelled with this before merging and removed do-not-merge/hold Some fixes necessary, hold for merging labels Jun 23, 2022

addressing error

9ca523d

ridavid2002 added do-not-merge/hold Some fixes necessary, hold for merging and removed ok-to-merge PRs should be labelled with this before merging labels Jun 23, 2022

ridavid2002 added 3 commits June 23, 2022 11:07

testing indentation error

5985eec

updating certman yaml

c271989

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

d8048c7

…opic/certmanagerbump

adding new line char

1864a8c

updating space

c28c18e

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

fa48466

…opic/certmanagerbump

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

eb39919

…opic/certmanagerbump

ridavid2002 added 2 commits July 12, 2022 09:18

updating apiVersion

6d5cd4c

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

65d831a

…opic/certmanagerbump

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

5e34b18

…opic/certmanagerbump

anujc25 reviewed Jul 13, 2022

View reviewed changes

pkg/v1/tkg/tkgconfigupdater/tkgconfigupdater_test.go Outdated Show resolved Hide resolved

v1 update

0d380d9

ridavid2002 added 2 commits July 14, 2022 12:44

reverting test.go changes

1b70fa5

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

02fe8b3

…opic/certmanagerbump

anujc25 approved these changes Jul 14, 2022

View reviewed changes

Merge branch 'main' of github.com:vmware-tanzu/tanzu-framework into t…

5d56488

…opic/certmanagerbump

ridavid2002 added ok-to-merge PRs should be labelled with this before merging and removed do-not-merge/hold Some fixes necessary, hold for merging labels Jul 15, 2022

vuil added priority/critical-urgent codefreeze required by a release codefreeze and removed priority/critical-urgent labels Jul 15, 2022

vuil merged commit 8824258 into main Jul 16, 2022

vuil deleted the topic/certmanagerbump branch July 16, 2022 01:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump cert-manager to 1.7.2 #2490

Bump cert-manager to 1.7.2 #2490

ridavid2002 commented May 25, 2022 •

edited

Loading

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 27, 2022

github-actions bot commented Jun 27, 2022

shyaamsn commented Jul 12, 2022

github-actions bot commented Jul 12, 2022

github-actions bot commented Jul 12, 2022

github-actions bot commented Jul 13, 2022

anujc25 left a comment •

edited

Loading

shyaamsn commented Jul 14, 2022

github-actions bot commented Jul 14, 2022

github-actions bot commented Jul 14, 2022

github-actions bot commented Jul 14, 2022

codecov bot commented Jul 14, 2022 •

edited

Loading

anujc25 left a comment

github-actions bot commented Jul 15, 2022

ridavid2002 commented Jul 15, 2022

Bump cert-manager to 1.7.2 #2490

Bump cert-manager to 1.7.2 #2490

Conversation

ridavid2002 commented May 25, 2022 • edited Loading

What this PR does / why we need it

Which issue(s) this PR fixes

Describe testing done for PR

Release note

PR Checklist

Additional information

Special notes for your reviewer

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 23, 2022

github-actions bot commented Jun 27, 2022

github-actions bot commented Jun 27, 2022

shyaamsn commented Jul 12, 2022

github-actions bot commented Jul 12, 2022

github-actions bot commented Jul 12, 2022

github-actions bot commented Jul 13, 2022

anujc25 left a comment • edited Loading

Choose a reason for hiding this comment

shyaamsn commented Jul 14, 2022

github-actions bot commented Jul 14, 2022

github-actions bot commented Jul 14, 2022

github-actions bot commented Jul 14, 2022

codecov bot commented Jul 14, 2022 • edited Loading

Codecov Report

anujc25 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 15, 2022

ridavid2002 commented Jul 15, 2022

ridavid2002 commented May 25, 2022 •

edited

Loading

anujc25 left a comment •

edited

Loading

codecov bot commented Jul 14, 2022 •

edited

Loading