Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Remove podcidr auto-fill when tkgs routable pod feature is enabled #2806

Merged

Conversation

chenlin07
Copy link
Contributor

@chenlin07 chenlin07 commented Jul 1, 2022

  • It's for enabling routable pod feature when creating tkgs cluster

Signed-off-by: Chen Lin linch@vmware.com

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #2060

Describe testing done for PR

Release note

When users want to enable routable pod feature for tkgs, they can set global variable `ENABLE_TKGS_ROUTABLE_POD` to `TRUE`. 
Also, users need to make sure that podcidr is empty when routable pod feature is enabled

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@chenlin07 chenlin07 requested review from a team as code owners July 1, 2022 00:30
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220701003943/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #2806 (6b886bf) into main (a334b86) will decrease coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
- Coverage   48.52%   47.59%   -0.94%     
==========================================
  Files         446      476      +30     
  Lines       44105    46159    +2054     
==========================================
+ Hits        21404    21970     +566     
- Misses      20658    22096    +1438     
- Partials     2043     2093      +50     
Impacted Files Coverage Δ
tkg/client/validate.go 61.37% <100.00%> (+0.12%) ⬆️
addons/controllers/machine_controller.go 65.65% <0.00%> (-3.04%) ⬇️
packageclients/pkg/packageclient/package_update.go 83.57% <0.00%> (-1.43%) ⬇️
addons/controllers/clusterbootstrap_controller.go 64.75% <0.00%> (-0.09%) ⬇️
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
...cluster/delete_machinehealthcheck_control_plane.go 16.66% <0.00%> (ø)
...lugin/isolated-cluster/fakes/client_imgpkg_fake.go 32.15% <0.00%> (ø)
...md/cli/plugin/cluster/delete_machinehealthcheck.go 19.23% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from 605fabd to cacf895 Compare July 12, 2022 00:18
@chenlin07 chenlin07 changed the title WIP: Add new CNI type antrea-nsx-routed Remove podcidr auto-fill when tkgs routable pod feature is enabled Jul 12, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220712002823/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch 2 times, most recently from 58b8ed2 to daaddee Compare July 18, 2022 23:36
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220718233940/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220718234534/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@vuil
Copy link
Contributor

vuil commented Jul 19, 2022

Thanks for the changes.
There are some linter errors in the Main CI run that needs fixing, otherwise lgtm.
Please add a note about the testing done.
And definitely add a release note since this has some user-facing implications.

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch 2 times, most recently from 4e0bd13 to 13fa282 Compare July 21, 2022 00:25
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220721003246/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220721003607/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from 13fa282 to a3ab420 Compare July 21, 2022 00:57
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220721010718/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from a3ab420 to 622631c Compare July 22, 2022 12:12
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220722122406/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from 622631c to 4324040 Compare July 25, 2022 08:20
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220725083100/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from 4324040 to bdcb7e5 Compare July 27, 2022 15:12
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220727152344/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from bdcb7e5 to 0bf8f0a Compare July 28, 2022 01:15
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20220728012609/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@randomvariable randomvariable self-assigned this Nov 14, 2022
- It's for enabling routable pod feature when creating tkgs cluster

Signed-off-by: Chen Lin <linch@vmware.com>
@chenlin07 chenlin07 force-pushed the topic/chenlin/accept-new-cni branch from 0bf8f0a to 6b886bf Compare December 6, 2022 00:59
@lubronzhan lubronzhan added the ok-to-merge PRs should be labelled with this before merging label Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2806/20221206021155/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@chenlin07 chenlin07 merged commit 88865cb into vmware-tanzu:main Dec 6, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tanzu cli won't fill podcidr when enabling routable pod feature in utkg
5 participants