Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Update clusterclass node pool support for TKGS #2900

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

tenczar
Copy link
Contributor

@tenczar tenczar commented Jul 11, 2022

What this PR does / why we need it

This change updates the node pool operations to support the TKGs clusterclass. Specifically it adds support for the nodePoolTaints, nodePoolVolumes, vmClass, and storageClass variables found in the tkgs clusterclass.

Which issue(s) this PR fixes

Fixes #2949

Describe testing done for PR

Release note

package-based-lcm: updates node pool API to properly support all node pool customization values, e.g vmClass, storageClass

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@tenczar tenczar requested review from a team as code owners July 11, 2022 17:37
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220711174614/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2900 (19bf6a8) into main (ad44231) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2900      +/-   ##
==========================================
- Coverage   43.96%   43.94%   -0.03%     
==========================================
  Files         416      416              
  Lines       41700    41788      +88     
==========================================
+ Hits        18332    18362      +30     
- Misses      21655    21708      +53     
- Partials     1713     1718       +5     
Impacted Files Coverage Δ
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (-3.34%) ⬇️
cmd/cli/plugin/cluster/get_node_pools.go 10.52% <0.00%> (+6.13%) ⬆️
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (-1.59%) ⬇️
pkg/v1/tkg/client/machine_deployment.go 61.86% <0.00%> (-5.81%) ⬇️
pkg/v1/tkg/client/machine_deployment_cc.go 71.16% <0.00%> (-15.89%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.28% <0.00%> (-0.62%) ⬇️
...ons/controllers/packageinstallstatus_controller.go 82.79% <0.00%> (+2.15%) ⬆️
pkg/v1/tkg/aws/client.go 20.33% <0.00%> (+6.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad44231...19bf6a8. Read the comment docs.

@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from 388dc9c to 2229232 Compare July 13, 2022 20:10
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220713202153/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from 2229232 to 50e5b66 Compare July 14, 2022 19:56
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220714200550/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from 50e5b66 to 44a3566 Compare July 14, 2022 21:01
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220714211014/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from 44a3566 to d1d9207 Compare July 14, 2022 21:47
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220714215835/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from d1d9207 to e512750 Compare July 14, 2022 22:28
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220714223721/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from e512750 to 68513ac Compare July 14, 2022 23:28
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220714233715/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

This change updates the clusterclass node pool operations to support
variables in the tkgs clusterclass such as vmClass, storageClass,
nodePoolTaints and nodePoolVolumes.
@tenczar tenczar force-pushed the tkgs_utkg_node_pool branch from 68513ac to 19bf6a8 Compare July 15, 2022 15:42
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2900/20220715155135/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please add #issue and release note as part of PR description before merging the PR.

@tenczar tenczar added the ok-to-merge PRs should be labelled with this before merging label Jul 15, 2022
@tenczar tenczar merged commit 464c63b into vmware-tanzu:main Jul 15, 2022
@tenczar tenczar deleted the tkgs_utkg_node_pool branch July 15, 2022 17:52
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Pool API for ClusterClass based clusters doesn't support all options for TKGs
3 participants