This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 192
Update CSI controller in tanzu-framework to set Zone for Paravirtual CSI #2926
Merged
maralavi
merged 12 commits into
vmware-tanzu:main
from
ridaz-zz:topic/ridaz/topology-support
Jul 18, 2022
Merged
Update CSI controller in tanzu-framework to set Zone for Paravirtual CSI #2926
maralavi
merged 12 commits into
vmware-tanzu:main
from
ridaz-zz:topic/ridaz/topology-support
Jul 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @ridaz! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
jvrahav
approved these changes
Jul 13, 2022
nehagjain15
reviewed
Jul 13, 2022
peterochodo
reviewed
Jul 14, 2022
peterochodo
reviewed
Jul 14, 2022
maralavi
reviewed
Jul 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #2926 +/- ##
==========================================
+ Coverage 43.99% 44.00% +0.01%
==========================================
Files 416 416
Lines 41849 41852 +3
==========================================
+ Hits 18411 18417 +6
+ Misses 21716 21714 -2
+ Partials 1722 1721 -1
Continue to review full report at Codecov.
|
maralavi
approved these changes
Jul 18, 2022
The changes look good to me. Thanks for adding the tests! |
10 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR will bring in the following changes:
Note: If default zone named,
vmware-system-legacy
is present, the topology flags need not be added.Which issue(s) this PR fixes
Fixes #2925
Describe testing done for PR
Deployed a TKC, and patched the
addons-controller
image to thetanzu-addons-controller-manager
deployment.PASSED
with validating if zone is set to true:Release note
PR Checklist
Additional information
Special notes for your reviewer