-
Notifications
You must be signed in to change notification settings - Fork 192
Adding support for TMC-Plugin discovery #2950
Conversation
a07b573
to
ebf57fe
Compare
Can you create a separate Github issue for this and link it in the PR description please? |
9a9c3ee
to
12654d4
Compare
a90d96f
to
2302ca3
Compare
Codecov Report
@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
+ Coverage 45.82% 45.95% +0.12%
==========================================
Files 361 391 +30
Lines 37642 40566 +2924
==========================================
+ Hits 17249 18641 +1392
- Misses 18820 20216 +1396
- Partials 1573 1709 +136
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LGTM @pgandigesang! Thanks for making the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs rebase. @pgandigesang Can you please help with the rebase as some of the code base has moved to cli/runtime
go module.
2302ca3
to
184fe49
Compare
Cluster Generation A/B Results: |
184fe49
to
de9496d
Compare
Cluster Generation A/B Results: |
I am confused why this commit 4cc3008 and changes related to this commit is shown as part of this PR? cc @pgandigesang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some issue with the rebase as some additional changes are shown as diff with this PR. But otherwise changes looks good.
Signed-off-by: prajwal gandige sangamesh <pgandigesang@vmware.com>
de9496d
to
92101e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: prajwal gandige sangamesh <pgandigesang@vmware.com> Signed-off-by: prajwal gandige sangamesh <pgandigesang@vmware.com>
What this PR does / why we need it
This change is required to add support for TMC-Plugin discovery.
Which issue(s) this PR fixes
Fixes #3204
Describe testing done for PR
Release note
PR Checklist
Additional information
Special notes for your reviewer