Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Conversation

codegold79
Copy link
Contributor

Signed-off-by: F. Gold fgold@vmware.com

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #2460

Describe testing done for PR

Release note


Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3012/20220722183233/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #3012 (00f3711) into main (8ac67dd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3012      +/-   ##
==========================================
- Coverage   44.15%   44.14%   -0.01%     
==========================================
  Files         416      416              
  Lines       42139    42141       +2     
==========================================
- Hits        18606    18604       -2     
- Misses      21808    21811       +3     
- Partials     1725     1726       +1     
Impacted Files Coverage Δ
pkg/v1/sdk/capabilities/discovery/tkg/fake.go 57.14% <ø> (ø)
.../v1/sdk/capabilities/discovery/tkg/capabilities.go 76.08% <100.00%> (+5.63%) ⬆️
...ons/controllers/packageinstallstatus_controller.go 77.99% <0.00%> (-1.16%) ⬇️
addons/controllers/clusterbootstrap_controller.go 63.28% <0.00%> (-0.62%) ⬇️
...ntroller/tkr-status/clusterstatus/clusterstatus.go 51.21% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73f092...00f3711. Read the comment docs.

Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79 codegold79 force-pushed the 2460-aws-e2e-test-verify-calico-cni-is-created-successfully-on-guest-cluster branch from e1b36b8 to 00f3711 Compare July 28, 2022 02:58
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3012/20220728030708/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codegold79
Copy link
Contributor Author

Since TKG Integration tests do not run on forks, I will close this PR in favor of PR 3031.

@codegold79 codegold79 closed this Jul 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TC11: AWS Cluster - Ability to create CC guest cluster on AWS with calico CNI and verify it is successful
2 participants