Use TKR API commands based on feature-gate on the supervisor-cluster

[anujc25]

What this PR does / why we need it

• Use TKR v1alpha3 API commands based on feature-gate on the supervisor-cluster
  Signed-off-by: Anuj Chaudhari anujc@vmware.com

Which issue(s) this PR fixes

Fixes #3040

Describe testing done for PR

1. tanzu login to vSphere8 based supervisor cluster which has TKR v1alpha3 API
2. Disable the feature-flag tanzu config set features.global.tkr-version-v1alpha3-beta false
3. Get the TKRs

~ $ tanzu kr get
  NAME                                 VERSION                            COMPATIBLE  ACTIVE
  v1.22.8---vmware.1-tkg.2-zshippable  v1.22.8+vmware.1-tkg.2-zshippable  True        True
  v1.23.5---vmware.1-tkg.1-zshippable  v1.23.5+vmware.1-tkg.1-zshippable  True        True

4. Deactivate and activate TKRs to verify it is taking effect

~ $ tanzu kr deactivate v1.22.8---vmware.1-tkg.2-zshippable
Applying patch to resource v1.22.8---vmware.1-tkg.2-zshippable of type *v1alpha3.TanzuKubernetesRelease ...

~ $ tanzu kr get
  NAME                                 VERSION                            COMPATIBLE  ACTIVE
  v1.23.5---vmware.1-tkg.1-zshippable  v1.23.5+vmware.1-tkg.1-zshippable  True        True

~ $ tanzu kr activate v1.22.8---vmware.1-tkg.2-zshippable
Applying patch to resource v1.22.8---vmware.1-tkg.2-zshippable of type *v1alpha3.TanzuKubernetesRelease ...

~ $ tanzu kr get
  NAME                                 VERSION                            COMPATIBLE  ACTIVE
  v1.22.8---vmware.1-tkg.2-zshippable  v1.22.8+vmware.1-tkg.2-zshippable  True        True
  v1.23.5---vmware.1-tkg.1-zshippable  v1.23.5+vmware.1-tkg.1-zshippable  True        True

Release note

Use TKR v1alpha3 API commands based on feature-gate on the supervisor-cluster

Additional information

Special notes for your reviewer

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3041/20220729212750/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[github-actions]

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3041/20220729215355/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

[codecov]

Codecov Report

Merging #3041 (0ff9591) into main (22d9820) will increase coverage by 0.02%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
+ Coverage   44.18%   44.21%   +0.02%     
==========================================
  Files         416      416              
  Lines       42142    42148       +6     
==========================================
+ Hits        18622    18634      +12     
+ Misses      21798    21791       -7     
- Partials     1722     1723       +1     

Impacted Files	Coverage Δ
pkg/v1/tkg/tkgctl/featuregate_helper.go	16.66% <7.14%> (-2.69%)	⬇️
pkg/v1/tkg/tkgctl/client.go	52.20% <100.00%> (ø)
...oller-manager/controllers/v1_cascade_controller.go	66.66% <0.00%> (-3.26%)	⬇️
...tanzu-auth-controller-manager/controllers/utils.go	72.58% <0.00%> (-1.62%)	⬇️
addons/controllers/clusterbootstrap_controller.go	63.28% <0.00%> (-0.62%)	⬇️
pkg/v1/tkg/client/cluster.go	14.43% <0.00%> (-0.03%)	⬇️
pkg/v1/tkg/client/upgrade_cluster.go	42.57% <0.00%> (+2.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d9820...0ff9591. Read the comment docs.

[prkalle]

LGTM. Thanks for the fix!

[saji-pivotal]

@anujc25 Nice work overall! Are these changes unit-testable?

[tenczar]

LGTM