Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix package plugin tests flakes #3096

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

shyaamsn
Copy link
Contributor

@shyaamsn shyaamsn commented Aug 6, 2022

What this PR does / why we need it

Fix couple of issues in package plugin:

  1. In slow testbeds applying registry server fails. Hence added retries
  2. kapp-controller PackageInstall reverts the changes to the kapp-controller configmap in workload cluster. Hence pausing the PackageInstall.

Which issue(s) this PR fixes

Fixes #3097

Describe testing done for PR

Ran package plugin integration tests and they pass

Release note

Fix package plugin tests flakiness

Additional information

Special notes for your reviewer

@shyaamsn shyaamsn requested review from a team as code owners August 6, 2022 05:56
@shyaamsn shyaamsn changed the title Fix package plugin tests flakiness Fix package plugin tests flakes Aug 6, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3096/20220806060439/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@shyaamsn shyaamsn force-pushed the fix_package_plugin_tests branch from 4656ee4 to 1daffe5 Compare August 6, 2022 16:45
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3096/20220806165311/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #3096 (1daffe5) into main (ac3165c) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
+ Coverage   44.40%   44.47%   +0.06%     
==========================================
  Files         417      417              
  Lines       42320    42320              
==========================================
+ Hits        18791    18820      +29     
+ Misses      21798    21776      -22     
+ Partials     1731     1724       -7     
Impacted Files Coverage Δ
...ons/controllers/packageinstallstatus_controller.go 79.15% <0.00%> (+1.15%) ⬆️
addons/controllers/clusterbootstrap_controller.go 65.57% <0.00%> (+2.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shivaani0505 shivaani0505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maralavi maralavi added the ok-to-merge PRs should be labelled with this before merging label Aug 7, 2022
@shyaamsn shyaamsn merged commit 08c6f96 into vmware-tanzu:main Aug 7, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package Plugin Integration Tests Flakes
4 participants